Closed toribr closed 6 years ago
Sorry, I didn't catch this before you merged, but in addition to adding the icon files, we need to reference them in the HTML head. This is currently happening in the component HtmlHelmet
HtmlHelmet
https://github.com/cityofaustin/grackl/blob/master/src/zilker/HtmlHelmet.js#L7
On the surface, it looks like we just need to add link tags: https://github.com/nfl/react-helmet#reference-guide
I also found this article that goes over this issues one person on the internet dealt with: https://medium.com/@cameronbourke/a-tale-of-favicons-and-react-dbcb4e7202e4
Sorry, I didn't catch this before you merged, but in addition to adding the icon files, we need to reference them in the HTML head. This is currently happening in the component
HtmlHelmethttps://github.com/cityofaustin/grackl/blob/master/src/zilker/HtmlHelmet.js#L7
On the surface, it looks like we just need to add link tags: https://github.com/nfl/react-helmet#reference-guide
I also found this article that goes over this issues one person on the internet dealt with: https://medium.com/@cameronbourke/a-tale-of-favicons-and-react-dbcb4e7202e4