search

cityofaustin / knackpy

A Python client for interacting with Knack applications
https://cityofaustin.github.io/knackpy/docs/user-guide/
Other
39 stars 18 forks source link

Typo correction in comment #103

Closed frankhereford closed 2 years ago

frankhereford commented 2 years ago

This PR intends to correct a typo in the docstring for the get method in app.py.

frankhereford commented 2 years ago

@frankhereford thanks for flagging this. we might as well rebuild the documentation website while we're at it (to keep the API reference in sync).

it's a bit cumbersome, but will be a good intro to the tooling for you. these docs cover that process.

unfortunately i do not have CI setup for the docs HTML. you're welcome to take a crack at that if you're feeling ambitious.

I would love to take a shot at it! I will dig into it here in the next day or two, and I am looking forward to learning more about how that process works. Thanks for the suggestion to give it a whirl, and I'll let you know how it goes.

johnclary commented 2 years ago

@frankhereford i rebuilt the docs and am bringing em in! The PyPI will bomb because this will trigger a duplicate publication of the same knackpy-dev package version, which is fine because this is purely Github pages HTML*. Related discussion.

Edit: right, this is a docstring edit. because we're not bumping version, it will be absent from knackpy-dev, but will be included in the next prod release.