Closed johnclary closed 2 years ago
This has been deployed to the knackpy-dev
package
Working on adding a test real quick...
I added a test and am merging. The developer docs for the test suite are pretty good, btw.
I saw that this check failed: https://github.com/cityofaustin/knackpy/runs/6031309455?check_suite_focus=true
Does it need to be retriggered in some way?
thanks @chiaberry — a faulty CI that tried to republish v.1.1.0 to PyPI.
I updated the Github action to only publish the dev package to PyPI on push. That means that any branch merged to dev
should include a version bump, but PRs against dev
won't push. I think that's the best way.
I pushed that action change to dev. I'm going to push a version bump to the dev
branch to v1.1.1
, which should publish a new version of knackpy-dev
and bring everything back in sync.
Fixes #109.
Consider this record, in which
field_1
is a date equation which renders days.field_2
is a numeric equation which renders a decimal result as an integer:According to previous behavior, formatting this record would look like this:
This is because we use knackpy's default formatter for the
equation
field type, which simply returns the record's "raw" value. That's not ideal, because the user presumably expects the formatted value (i.e., the value Knack renders in the UI).In these cases, we can override Knackpy's default formatting behavior by adjusting the field settings, here.
Here's where
use_knack_format
is applied in theRecord
class.This is reasonable expected behavior from the knackpy API—so lets do it. This is definitely a breaking change. Bumped to
v1.1.0
.