Support changing MAX_ROWS_PER_PAGE

cityofaustin / knackpy

A Python client for interacting with Knack applications

https://cityofaustin.github.io/knackpy/docs/user-guide/

Other

39 stars 18 forks source link

Support changing MAX_ROWS_PER_PAGE #90

Closed aidanlister closed 3 years ago

aidanlister commented 3 years ago

Could we pass this in as a kwarg?

johnclary commented 3 years ago

@aidanlister i don't see why not. You probably gathered that at the moment we're setting to 1000 or the record_limit, whichever is lower. Can you spell out the use case for limiting max rows per page vs just using the overall record_limit?

aidanlister commented 3 years ago

It turns out this wasn't the problem, the problem was actually https://github.com/cityofaustin/knackpy/issues/91 ... so maybe there's not as much of a need to support this.

johnclary commented 3 years ago

Was hoping that was the case. Closed.