cityofaustin / knackpy

A Python client for interacting with Knack applications
https://cityofaustin.github.io/knackpy/docs/user-guide/
Other
39 stars 17 forks source link

Make App._download_files() a static method #93

Open johnclary opened 3 years ago

johnclary commented 3 years ago

App._download_files() is in fact a static method. We should decorate it as such and drop self in case someone wants to use it as such. Say, for example, you're doing some crazy file migration and you want to monkey patch knackpy for assistance. Me IRL.

I guess it might be more elegant to move the method into Knackpy.api, since that's where the rest of our low-level API methods exist.

The current workaround is to just construct an app instance and call the method manually, which isn't hard.

https://github.com/cityofaustin/knackpy/blob/3ab9c2976be408db60c463eb9d663fc14e587a55/knackpy/app.py#L425