cityofaustin / techstack

Project management for the City of Austin's new digital service delivery platform, Austin.gov.
11 stars 3 forks source link

Padding for topic card on topic collection page #3328

Closed desigonz closed 4 years ago

desigonz commented 5 years ago

Describe the bug Padding seems funny at this breakpoint; larger breakpoints look normal. image

URL https://alpha.austin.gov/en/health-safety/disaster-safety-relief/

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Current behavior

Expected behavior

Screenshots

Device

Browser

Additional context

desigonz commented 5 years ago

Assigning to @chasechenevert to investigate.

gumbeauuu commented 4 years ago

I think i've figured it out~ Changing left and right margins from auto to 0 seems to do the trick.

margin-left: 0;
margin-right: 0;

This takes care of the bug reported, but there are a few other small issues here that I'll address in separate issues soon.

Before

Row of 2 The second topic collection card has more left and right margin than the first, it should match the first.

Screen Shot 2019-11-13 at 10 35 08 AM

Vertical list Both cards have different spacing, neither are as intended.

Screen Shot 2019-11-13 at 10 43 04 AM

After

Row of 2 Margin is consistent.

Screen Shot 2019-11-13 at 10 36 44 AM

Vertical list Margin is consistent.

Screen Shot 2019-11-13 at 10 37 10 AM
gumbeauuu commented 4 years ago

Ready for ya, @desigonz

desigonz commented 4 years ago

Great! Reassigning this to dev.

Acceptance criteria

chiaberry commented 4 years ago

deployed link: https://janis-3328-padding-topic-card.netlify.com/en/health-safety/disaster-safety-relief/

desigonz commented 4 years ago

Looks great! QA done.