cityofaustin / techstack

Project management for the City of Austin's new digital service delivery platform, Austin.gov.
11 stars 3 forks source link

Localize documents in official documents #4076

Closed easherma closed 4 years ago

easherma commented 4 years ago

Acceptance criteria


Describe the bug

Janis shows the English version of document, and Joplin doesn't allow for localized Spanish doc

URL

To Reproduce

Go to https://alpha.austin.gov/en/police-oversight/office-of-police-oversight-official-reports#1 Switch to Spanish Click a document link Observe english document

Current behavior

A clear and concise description of what happened

Expected behavior

A clear and concise description of what you expected to happen

Screenshots

Device and browser

Additional context

desigonz commented 4 years ago

Documents aren't localized for Spanish and English in the data model on the Joplin side. That makes sense for OPO's disciplinary documents, which are official documents with things like redactions and signatures that make it difficult to translate, so we just include the translated description, but link to the document. cc @srigdon and @toribr.

However, @ablangworthy27 was trying to publish the translated full racial profiling report. Amanda, did that come from OPO directly, or was that something we did?

Would love to hear y'all's thoughts. We'll need to decide if we want localized document uploads for official document entries before moving forward.

ablangworthy27 commented 4 years ago

@desigonz the translated report came from OPO.

desigonz commented 4 years ago

Okay good to know! Sounds like that's a user need, then. @srigdon/@toribr, any additional thoughts?

toribr commented 4 years ago

So, in the SP version, the link would be in Spanish and link to the Spanish doc? In that case, then it seems like the 1-1 relationship we hope to have with translations would work, ie, user enters Spanish version, and links to the Spanish document. Is that what we're thinking?

desigonz commented 4 years ago

Yep, that's spot on! And for disciplinary docs that we don't translate, the link to the English doc will still appear. I'll update acceptance criteria above.

toribr commented 4 years ago

Sounds good. If no Spanish doc is linked, then system will show the English version.

easherma commented 4 years ago

Also at this point if it really isn’t going to work couldn’t we just manually make the field for Spanish document similar to what we do for Streamfields?

chiaberry commented 4 years ago

@ablangworthy27 for testing https://janis-4076-local-docs.netlify.com/es/health-safety/policing-in-austin/police-feedback-and-records/official-complaint-and-discipline-documents/#1 is the janis

and https://joplin-pr-4076-local-docs.herokuapp.com/admin/pages/search/ is the linked joplin.

I replaced the first entry on janis (the last one on joplin) with a fake spanish pdf, you can see it by clicking the first document on janis. other documents that were not replaced with a spanish one still have the english document.

ablangworthy27 commented 4 years ago

This looks good!