Contacts on Janis crash if Facebook links don't include trailing slashes

cityofaustin / techstack

Project management for the City of Austin's new digital service delivery platform, Austin.gov.

11 stars 3 forks source link

Contacts on Janis crash if Facebook links don't include trailing slashes #5012

Closed chiaberry closed 3 years ago

chiaberry commented 4 years ago

Describe the bug

If on joplin you set the facebook url as facebook.com/AustinFireDepartment, the component will crash in Janis. it is looking for facebook.com/AustinFireDepartment/

URL

To Reproduce

Steps to reproduce the behavior example:

Go to '...'
Click on '....'
Scroll down to '....'
See error

We need to adjust the regex, add a error boundary? have it choose the correct match group instead of going for one that is undefined.

chiaberry commented 3 years ago

https://janis-v3-5012-contact-slash.netlify.app/ is the janis

is the linked joplin https://joplin-pr-4907-remove-importer.herokuapp.com/admin/snippets/contact/contact/1/

jairPineros commented 3 years ago

issue was resolved by dev:

Screen Shot 2020-10-30 at 1.52.37 PM.png