search

cityssm / bulma-sticky-table

A Bulma-friendly way to stick a table header, table footer, first column, or all three!
https://cityssm.github.io/bulma-sticky-table/
MIT License
26 stars 1 forks source link

Support Bulma v1.0? `$table-cell-border` undefined variable #22

Open hedyhli opened 1 month ago

hedyhli commented 1 month ago

Hello, I really appreciate you making this plugin to make freezing columns and headers easier for Bulma tables.

I tried using it through npm install + @import with SCSS, and I'm getting:

[plugin:vite:css] [sass] Undefined variable.
   ╷
22 │       border: $table-cell-border;
   │               ^^^^^^^^^^^^^^^^^^
   ╵
  node_modules/.pnpm/@cityssm+bulma-sticky-table@2.1.0/node_modules/@cityssm/bulma-sticky-table/_sticky-table.scss 22:15  root stylesheet
/Users/hedy/projects/indecisive-solid/node_modules/.pnpm/@cityssm+bulma-sticky-table@2.1.0/node_modules/@cityssm/bulma-sticky-table/_sticky-table.scss:22:15

I'm using Bulma v1 here. I noticed the repo hasn't been updated since last year, and Bulma v1 might've been released after the last update, so perhaps this is a Bulma v1 incompatibility issue here?

Thanks!

dangowans commented 1 month ago

You hit the nail on the head @hedyhli .

Bulma v1 changed a lot of variable names, unfortunately making it incompatible with quite a few of our Bulma-related packages. Hoping to get to this at some point.

dangowans commented 1 month ago

I was able to get the CSS to compile with Bulma v1. Not sure about the look and feel though. Some of the table styles changed in v1.

dangowans commented 1 month ago

The Bulma v1 version has been published to npm as v3.0.0. Hopefully it will solved your issue.

https://github.com/cityssm/bulma-sticky-table/releases/tag/v3.0.0