search

ciudadanointeligente / write-it

App to create and send messages to public persons. It's a component of POPLUS project.
poplus.org
GNU General Public License v3.0
38 stars 23 forks source link

allow messages created before moderation enabled to be moderated #1177

Closed struan closed 8 years ago

struan commented 8 years ago

Prevent an exception being thrown when moderating a message confirmed before moderation for all messages by creating the moderation object at moderation time.

Fixes #704

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.03%) to 98.241% when pulling d3dd490c0fbe427a93c7d2cf6d5657cf2054878e on 704-moderation-for-all into a9ca20d0b8daade3d3abd59a7467a429ccd69d28 on alpaca.

mhl commented 8 years ago

Prevent an exception being thrown when moderating a message confirmed before moderation for all messages by creating the moderation object at moderation time.

Could this commit message be a bit clearer? (I think the way it's expressed in the issue is easier to understand.) Maybe just leaving out "for all messages"?

mhl commented 8 years ago

:+1: Looks good - I left a few comments, but they're all very minor things.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.04%) to 98.23% when pulling c25d874f56b7b49e7e7699edc1e0907ff13b35e5 on 704-moderation-for-all into a9ca20d0b8daade3d3abd59a7467a429ccd69d28 on alpaca.

mhl commented 8 years ago

In @struan's absence I've squashed those additional commits and slightly edited the commit message - I hope that's OK. (The alpaca branch can still be rewritten without much consequence, if not, of course.)

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.04%) to 98.23% when pulling 35f547758897b8027a0d1dcc021e9d349d2c58a3 on 704-moderation-for-all into 1dae2d99d6733b1a313fb8a33d40f0f678dc0b04 on alpaca.