move moderation to web based queue - Githubissues

ciudadanointeligente / write-it

App to create and send messages to public persons. It's a component of POPLUS project.

poplus.org

GNU General Public License v3.0

38 stars 23 forks source link

move moderation to web based queue #1178

Closed struan closed 8 years ago

struan commented 8 years ago

This PR turns off the email based moderation and instead adds a page in the /manage/ section of an instance with a queue of messages to be moderated.

Moderation of messages then takes place on the message detail page with the addition of a Reject button along side the existing Accept button.

This also fixes some existing issues:

If moderation is off then all public messages are marked as moderated upon confirmation
An error is thrown if a previously moderated message is moderated again
Prevents moderation being turned off if there are messages in the moderation queue

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 98.068% when pulling bd7049d0c821be80ebc0fd4b42ce03882c27a281 on 923-moderation-admin into a9ca20d0b8daade3d3abd59a7467a429ccd69d28 on alpaca.

mhl commented 8 years ago

The biggest issue for me here, before really considering the content, is that this turns off the email based moderation completely. I'd been assuming that we're planning to merge the alpaca branch into master as soon as we're happy with it, in which case we wouldn't want to turn off email moderation for every existing instance. Could there be a feature flag per instance for this?

coveralls commented 8 years ago

Coverage decreased (-0.08%) to 98.196% when pulling 04aa17adda2c733d9bec170d422efb68a0463936 on 923-moderation-admin into a9ca20d0b8daade3d3abd59a7467a429ccd69d28 on alpaca.

mhl commented 8 years ago

I've rebased this now, which involved resolving a conflict between 35f547758897b8027a0d1 and 88e3c97cb4f

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 98.083% when pulling 3325e3c358c2374abccefe1c22f1cc01ccf163bc on 923-moderation-admin into 11258b249a4cadc3f43eb703a99180c99719df38 on alpaca.

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 98.119% when pulling 0738a500ed8dbe2721d378baef478ff36c0a1ad7 on 923-moderation-admin into 11258b249a4cadc3f43eb703a99180c99719df38 on alpaca.

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 98.119% when pulling b4b8c9f6db6363c1ca32ebbd6bf7bc669b382013 on 923-moderation-admin into 11258b249a4cadc3f43eb703a99180c99719df38 on alpaca.