ciudadanointeligente / write-it

App to create and send messages to public persons. It's a component of POPLUS project.
poplus.org
GNU General Public License v3.0
38 stars 23 forks source link

Error messages on data source loading are unclear #1218

Open equivalentideas opened 7 years ago

equivalentideas commented 7 years ago

We've got an error on a data source "error — last updated Sept. 26, 2017, 12:20 a.m":

screen shot 2017-09-26 at 12 04 23 pm

It's not clear what is causing this error or what we can do to fix it.

We've also got an error on an old data source, that contains some people with the same popolo id, in case that's relevant (it's not clear what's causing that error either ;-P ):

screen shot 2017-09-26 at 12 04 16 pm

equivalentideas commented 7 years ago

Also, some quick help to resolve this error would be highly appreciated 🙏

mhl commented 7 years ago

As I've mentioned before, we (mySociety) are only working on the Django 1.8 / django-popolo version of write-it now, which has moved on considerably from the version deployed on writeinpublic.com, but hopefully I can help find the problem with the data anyway...

I think the first error, which isn't being displayed in the interface, is a ValidationError for an invalid email address in:

    "email": "http://www.coonambleshire.nsw.gov.au/AboutCouncil/keadys@bigpond.com", 
    "id": "coonamble_shire_council/danny_keady", 
    "image": "http://www.coonambleshire.nsw.gov.au/2015/_media/content/councillors/danny-keady.jpg", 
    "images": [
        {
            "url": "http://www.coonambleshire.nsw.gov.au/2015/_media/content/councillors/danny-keady.jpg"
        }
    ], 
    "name": "Danny Keady", 
    "sources": [
        {
            "url": "http://www.coonambleshire.nsw.gov.au/AboutCouncil/councillors.html"
        }
    ]
}

So hopefully if you fix that and resync, it'll start working again.

I don't think the second error is relevant: that URL is a 404, so it looks like it's trying to parse the error page as JSON. (Obviously that should be checking the status code to produce a more helpful error.)

equivalentideas commented 7 years ago

As I've mentioned before, we (mySociety) are only working on the Django 1.8 / django-popolo version of write-it now, which has moved on considerably from the version deployed on writeinpublic.com, but hopefully I can help find the problem with the data anyway...

Thanks so much for this @mhl I really appreciate it. I'm looking into your suggestion now.

equivalentideas commented 7 years ago

So hopefully if you fix that and resync, it'll start working again.

Unfortunately it's still showing an error. Would you mind checking what the error is now for me? I really appreciate your help with this @mhl 🙏

I don't think the second error is relevant: that URL is a 404, so it looks like it's trying to parse the error page as JSON. (Obviously that should be checking the status code to produce a more helpful error.)

Yep that's expected 👍