ciur / papermerge

Open Source Document Management System for Digital Archives (Scanned Documents)
https://papermerge.com
Apache License 2.0
2.55k stars 267 forks source link

docs: Do not expose media directory #403

Closed maxtruxa closed 2 years ago

maxtruxa commented 3 years ago

Description

Do not instruct users to expose the media directory unprotected. This is unsafe and as far as I can tell not necessary for normal operation of a Papermerge instance.

Serving the media directory straight through the webserver circumvents all access controls present in the web frontend and the REST API, leaving user data unprotected. Anyone who gets access to a valid document link can access that document. If the user's webserver has directory listings enabled, this turns into a complete disaster, as all files are immediately discoverable and accessible.

My only guess is, that this might have been required in previous versions of Papermerge?

Type of change

How Has This Been Tested?

n/a

Checklist:

ciur commented 3 years ago

Thank you for opening this pull request. I will review it and come back with feedback.

ciur commented 2 years ago

This PR is not relevant anymore. Papermerge now is deployed only via docker images.