civfanatics / CQUI_Community-Edition

Civilization 6 mod - UI enhancements, reduce clicks and manage your empire faster!
MIT License
149 stars 28 forks source link

Updated BTS Integrated Mod #282

Closed the-m4a closed 3 years ago

the-m4a commented 3 years ago

Turn on the ignore whitespace when looking at this PR!

Updated the BTS Integrated Mod after I saw that there was an issue with properly calculating Portugal's numbers. Someone on Steam Workshop had mentioned that a user on the BTS Mod page had offered up a solution for fixing that.

This code is just from the BTS mod, with a couple of changes relating to the CQUI Settings and how they're applied.

I played a bit last night and it seemed okay.

the-m4a commented 3 years ago

yeah, there's two versions of it - it was included in CQUI long ago and while the right thing to do would probably be to remove it, I noticed BTS hadn't actually been updated since last year so it may be a scenario where we'd end up removing a mod and pointing folks at something that is no longer updated.

Couple of things though - I was thinking about ensuring the CQUI version of the mod does not get loaded if the standalone of that same mod is also loaded. This creates a problem for the CQUI settings menu as it depends on the integrated More Lenses mod... I've wanted to move the CQUI settings for a while now but haven't yet tried to tackle that. Anyway, ensuring the standalone version of a mod would load is probably something that is reasonably done, as we can check for other enabled mods in our modInfo file (for example, the modinfo looks to see if Extended Diplomacy Ribbon is in use, and loads files with different load-order values depending on whether or not it's there)

Regarding the readme... good call. I updated it and pushed the change. At least clarified it a little and put some bold text there.