search

civfanatics / CQUI_Community-Edition

Civilization 6 mod - UI enhancements, reduce clicks and manage your empire faster!
MIT License
154 stars 28 forks source link

Update the integrated MoreLenses Mod #292

Closed the-m4a closed 3 years ago

the-m4a commented 3 years ago

Basically: it's dangerous to say "trust me" on these things, but trust me... all of this stuff consists of updating our integrated version of the MoreLenses mod to match what is released on Astog's GitHub (https://github.com/astog/MoreLenses). So it looks like a whole mess of changes, but in reality there's not a lot there in terms of what I did to Astog's code for CQUI. You're welcome to pour through it if you're into that kind of staring at XML and Lua. :)

Some stuff I wanted to mention:

  1. The MoreLenses Workshop page states users with CQUI do not need to subscribe separately to MoreLenses, which implies we should continue to maintain this
  2. I'm going to create an issue on Astog's page to re-confirm our integrating this into CQUI is okay
  3. See #215 - in the same issue I create with the item above, I will offer to help integrate the color changing into MoreLenses base mod
  4. I do want to, in the future, set up CQUI to only load the integrated MoreLenses if the MoreLenses mod isn't already loaded (I had intended to include that here, but did not)
  5. The updated MoreLenses is necessary to do what I am trying to do in issue #215
  6. It annoys me a bit that some of the file renames were processed correctly (showing as renamed in the file changes) while others did not (showing as delete one file, add a new other file).

I've been testing this, but I wanted to get this up here because my local version of this branch has all of the changes for the lens custom coloring, and I didn't want to push those changes up with this PR.