civfanatics / CQUI_Community-Edition

Civilization 6 mod - UI enhancements, reduce clicks and manage your empire faster!
MIT License
149 stars 28 forks source link

Colors of Lenses added via MoreLenses integration can be configured #300

Closed the-m4a closed 3 years ago

the-m4a commented 3 years ago

Ready for Review

What this is (short summary)

How best to Review This or Test this

More Details and Stuff

Settings menu (scrolled slightly and rest of the way) image image

Gifs taken before I added the rest of the lenses to the menu, but the behavior is still the same:

Sliders update the preview box; can just add values directly in the text boxes, and the default button returns that lens to the usual More Lenses color. When the setting is changed, it shows as yellow. When the gif restarts it reverts to pink. BuilderLensColor1 BuilderLensColor2

the-m4a commented 3 years ago

Oy... this is turning into a monster but it works so far

image

the-m4a commented 3 years ago

Updated the title and the text on the first post.

RustyD commented 3 years ago

This is an impressive update! I have a question: how do a specify a 'neutral' color? For example, on the 'Resources' lens, I don't tend to care too much about bonus resources, so I might not want them colored at all. Would I just set the color to 'white' or 'black'? Or is this not possible the way the feature is currently written? I'm not sure if some people are effectively asking for 'no coloring' for some things on some lenses? (I might be wrong). I fully appreciate it would be a lot more work to implement - I am just asking the question! ;-)

the-m4a commented 3 years ago

@RustyD thanks - at the moment the best way is probably just to set the "neutral" color to black, it's the least intrusive. I was giving some thought to adding a "disable" button to go along with the default button in order to turn a color off

For example - this is setting Black for all resources when looking with the Builder lens - the Tobacco should be the only Resource not worked in the picture image