civfanatics / CQUI_Community-Edition

Civilization 6 mod - UI enhancements, reduce clicks and manage your empire faster!
MIT License
149 stars 28 forks source link

Citizen repaint bug #329

Open wayneb64 opened 2 years ago

wayneb64 commented 2 years ago

Sometimes, mostly actually, when you click a citizen slot to assign one it renders the lock icon correctly buy fails to paint it green. Clicking the City Breakdown icon will trigger a proper repaint. Easily worked around but getting annoying. Been there since the final set of updates, or the one before it.

image

the-m4a commented 2 years ago

Figured out what this is, fixed it Also took care of something that has bothered me for some time while I was in there - I added a "drag threshold" with the purchase tile button. Before if you dragged the mouse even the tiniest bit while trying to click on the purchase button, it would not do the purchase. Now, you can drag the mouse a tiny bit and it'll do the purchase.

I'll publish the branch now and create a PR

the-m4a commented 2 years ago

330 is the PR. Hopefully someone is still around to approve it. :)

wayneb64 commented 2 years ago

Did this get pushed to Steam already? I didn't see the bug while playing for a few hours yesterday.

the-m4a commented 2 years ago

Not yet, no

Sent from my iPhone

On Sep 19, 2021, at 6:07 AM, wayneb64 @.***> wrote:



Did this get pushed to Steam already? I didn't see the bug while playing for a few hours yesterday.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcivfanatics%2FCQUI_Community-Edition%2Fissues%2F329%23issuecomment-922470995&data=04%7C01%7C%7C9af01932422148bcca0708d97b6e60aa%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637676536258566493%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=D031dhnK9gI3lcYLfeWOjH5eJ5g5x3PfIc67WlWJWck%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACDBNOCUTLHAQCS6RII544DUCXN7RANCNFSM5C7R6KDA&data=04%7C01%7C%7C9af01932422148bcca0708d97b6e60aa%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637676536258576488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=M%2BZIIiHgDoHA4PHlz7eBbl8bOnGlOXKqATlIZsxkMkY%3D&reserved=0.

wayneb64 commented 2 years ago

That's really strange as usually I hit it a lot and I didn't notice it fail at all. I will keep an eye out today, maybe I just missed it.

wayneb64 commented 2 years ago

Saw it plenty yesterday, guess I just got lucky the day before.

wayneb64 commented 2 years ago

I thought I saw this was fixed and in the last update, maybe not:

image