civic-data-design-lab / atlas-lighting

atlas-of-lighting-web-application
4 stars 6 forks source link

SELECTED CELL update: Report card on the right panel. #99

Closed egeozin closed 7 years ago

cosmicespresso commented 7 years ago

Create a report card on the right which shows values when the cell is selected.

hgunc commented 7 years ago

in report card view, we'll have to keep the instagram thumbnails and street view as it is.

Also for business types and instagram content topics, it can be a string of top 3 types or topics.

Example: Health, Retail, Service

And the dataset name could be renamed as Top 3 Businees Types in this Cell

cosmicespresso commented 7 years ago

@egeozin did you move parts of the jQuery controlling the behavior out of the grid_map.js? Can't find the parts that control the click and fold events on the left and right panels.

egeozin commented 7 years ago

Yep, I put them under control.js. Sorry, I put a notice here two weeks ago and then closed it.

cosmicespresso commented 7 years ago

Cool, I found them and am almost done with this issue.

Questions

  1. What is the status of the topicsData?

  2. Should we entirely move the Google Street view and the Instagram Thumbnails to the "Cell View" tab?

egeozin commented 7 years ago

What do you mean? Do you mean the script running on the linux machine? Or do you mean whether we have it for LA and Chicago? (We are waiting for the merged csv file(with topics) for LA. As for the Chicago, we are waiting for the script to end in the compute engine(that will output aggregate topics), it shows 3 days)

Another question: have you updated the pittsburgh_grid.csv under the data folder recently?

cosmicespresso commented 7 years ago

Oh right, I completely forgot we were still waiting for that stuff to compile. Ok so for the moment I don't show anything for the Instagram topics in the CELL VIEW.

Regarding your question: Yes I changed the instagram likes to the correct naming (I'm pretty sure thats what I did at least).

How about the second question above? (Sorry I just modified my post so you might have missed it). I was thinking that the Google Street view and the Insta thumbnails are always cell-specific, so it makes sense to show them in that separate tab? 🤔

egeozin commented 7 years ago

Your response to the second question is great! Let's do that, we do not need to show them in the map view at all.

Another thing: have you noticed the small disconnect in the left border line of the map - view, I will open another thread regarding whether we should make that "drag a dataset to upload" box, but before that it may be due to recent changes in css.

egeozin commented 7 years ago

With your response, we are also circumventing the problem of incoherent google street view api problem(It sometimes shows sometimes not due to connection with google's api ). This way it will not be distracting in the map view tab.

By the way can you try panning in the map? You are selecting the cells don't you? If not, I will continue to wonder why do I always select a cell whenever I pan :)

cosmicespresso commented 7 years ago
  1. Panning Yes the UX is not great - but it gets better once I zoom in a little bit. The way you deal with panning is probably by being careful with the jQuery events, and/or a Mapbox panning property. Not sure we have the time for that...

  2. Google street + Instagram thumbnails Great, I will incorporate them in the CELL VIEW. Do you think that we should just take them out of the left hand side then? As in, they automatically show up only when we have selected a single cell, and they can not be dragged and dropped off. Sounds like a big change but makes sense to me. Maybe we check with Hayro?

  3. Left border disconnect I know, and it bothers me, will try to fix it later :) image

egeozin commented 7 years ago
  1. It's no big deal, I may try to enhance it if it becomes intolerable(highly unlikely).

  2. Wonderful, let's do that, we can take it back according to feedback.

  3. Don't bother, I can look into that, after you finish your css changes.

cosmicespresso commented 7 years ago

Here is the state so far:

image

@hgunc what do you think of the design?

Still need to be addressed:

@egeozin any ideas about that? I see some errors in the console but they seem to be from Instagram photos not properly loading from Firebase.

image

egeozin commented 7 years ago

Yep, these two errors you mentioned looks like they are related with Google's external and internal API calls. You make some refreshes and hope for the best, I have tried to fix it but I see similar complains around the web, let me look what to do about it.

In the instagram thumbnails case, those errors are due to the output of callback we are receiving from the Google API. So when a user deletes an image, the api asks with an obsolete link. I can try to find a way to hide the callback error print.

egeozin commented 7 years ago

Now, I cannot see instagram thumbnails for LA, have you changed anything?

cosmicespresso commented 7 years ago

No I haven't, I also don't see them. Can you check something - I told Dennis but he not sure if he updated anything: I have noticed that the formats of LA.csv and LA_grid.csv seem to not look like the rest of the [city].csv and [city]_grid.csv files. In fact they seem to be mixed up (the LA.csv looks like the Chicago_grid.csv for example). Maybe this has also bled into how the Firebase database is hit? Not sure why LA only has this issue.

Update: image

?? It showed up after 2 minutes.

egeozin commented 7 years ago

Yeah it shows up, but no images inside, it's probably related to the firebase. I just checked the firebase and I cannot access the database except a loading spinner(Hmm, site related problems I guess). So, yesterday, I changed the api query for other cities, as the database containing links to images for those cities have a different format than LA's. However, I triple-checked that I was able to see the images for LA(because I kept the query for LA, I only change the query when other cities are selected, so it's not related with our script).

So for the strangeness in LAgrid.csv file, it's because there are no fields with "insta{number}" in LA. Also, The reason for undefined insta_likes in LA is that there is no insta_like field. I will double check with Dennis, I assume an update on it.

We are not using the csv's with no "grid" in it, I will also get rid of them soon, as there are lots of unused junk out there.

cosmicespresso commented 7 years ago

I see. Sounds like there is no immediate solution..how about we open a separate bug issue for the Insta thumbnails and Google street view and close this one?