search

civic-jabber / data-ingest

Utilities for ingesting data pertaining to state and local political issues
MIT License
0 stars 0 forks source link

publish workflow for github actions #17

Closed kvnkho closed 3 years ago

kvnkho commented 3 years ago

I know the initial issue said on tag creation but it seems people do it on releases. Do we need it on tags? Releases seem appropriate.

Not quite sure how to test this without publishing to PyPi

MthwRobinson commented 3 years ago

@kvnkho -- Releases work for me. I'll test this locally using the PyPI creds a little later.

kvnkho commented 3 years ago

i believe this is done.

aside from comments above, i also added init.py files for the setup.py to capture these modules when it calls find_packages().

just a note that i had to use anaconda to install the dependencies failing on windows to test it.

i also feel it's very hard for users if versions are pinned with == rather than >= or <=.

MthwRobinson commented 3 years ago

Thanks! One final comment for setup.py - I think we also need to add package data to include the config .yml files and the Jinja templates in the build. Could you add that in as well?

kvnkho commented 3 years ago

Added data files and tested. They are now present in wheel file.

MthwRobinson commented 3 years ago

Working for me locally. LGTM. Thanks!! :-)