search

civiccc / react-waypoint

A React component to execute a function whenever you scroll to an element.
MIT License
4.08k stars 208 forks source link

Unable to resolve dependency tree #347

Open danyi1212 opened 3 years ago

danyi1212 commented 3 years ago

Hey, I'm getting those errors when trying to install this module:

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: material_dash@0.1.0
npm ERR! Found: react@17.0.1
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0" from react-waypoint@9.0.3
npm ERR! node_modules/react-waypoint
npm ERR!   react-waypoint@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Is that because the react version? React 17 is not supported?

Sergecodes commented 3 years ago

@danyi1212 Yeah, I think that's why. I did "npm i react-waypoint --force" to workaround this.

renatobenks commented 3 years ago

I think it should be closed once react@17 is already as peer dependency over here https://github.com/civiccc/react-waypoint/blob/master/package.json#L39

renatobenks commented 3 years ago

cc @lencioni @trotzig

DesignByOnyx commented 3 years ago

The latest published version v9.0.3 (from July 2020) does not contain this fix, which was added in Nov. 2020.

slorber commented 3 years ago

Can someone release the code on master please?

@lencioni @trotzig @sds @eslingerbryan @johndotpub @jamesplease

renatobenks commented 3 years ago

@lencioni shouldn't you close this one once it was solved since https://github.com/civiccc/react-waypoint/releases/tag/v10.0.0?