civiccc / react-waypoint

A React component to execute a function whenever you scroll to an element.
MIT License
4.08k stars 208 forks source link

onEnter and onLeave horizontal is triggered on vertical scroll #351

Open ghost opened 3 years ago

ghost commented 3 years ago

Expected Behavior

onEnter and onLeave are triggered when the component enters and leaves the viewport when the parent div is scrolled horizontally, when prop horizontal is given.

Current Behavior

onEnter and onLeave correctly inform if the component is in view, but they are only triggered when the page is scrolled vertically.

Steps to Reproduce

Component

<Waypoint
            horizontal={true}
            onEnter={_handleWaypointEnter}
            onLeave={_handleWaypointLeave}
          />

Handlers

const _handleWaypointEnter = () => {
    setInView(true);
    setChangeCount(changeCount + 1);
  };
  const _handleWaypointLeave = () => {
    setInView(false);
    setChangeCount(changeCount + 1);
  };

React: 17.0.2

react-waypoint: 9.0.3