search

civicmakers / client

This is the code repository for the CivicMakers knowledge sharing experiment.
http://civicmakers.firebaseapp.com
GNU General Public License v3.0
4 stars 9 forks source link

Consolidated build dependencies into npm scripts + doc updates #191

Closed therebelrobot closed 8 years ago

therebelrobot commented 8 years ago

The original installation method pollutes the users npm global install, and doesn't provide consistent versioning for grunt and bower. I've moved both bower and grunt-cli to dev dependencies and added postinstall script to install bower deps, and develop to run develop server.

This way, if you have all the dependencies already, you only need to enter npm install and npm run develop, and it will install/serve the app.

Also updated README to include dependency information and installation instructions that work for Linux as well as Mac. The original instructions also didn't include instructions on installing sass, which won't necessarily be installed on new devs systems.

therebelrobot commented 8 years ago

Just saw the failing build. will fix.

therebelrobot commented 8 years ago

So I tried even running the tests on master, and they failed even then, so I'm not sure if this was a breaking change on my end.

I also updated the README to install v0.10 of Node, though you should look towards updating to the latest LTS of Node (v4.x)

ybentz commented 8 years ago

@therebelrobot thanks for the PR. We don't use travis at the moment since we don't really have any tests yet. We set it up a while ago but didn't get to actually using it.. Sorry for the confusion. As for the additions, it looks good but I don't think that the '--force' for grunt test should be added because it will allow developers to also bypass the linters and other issues without noticing.

therebelrobot commented 8 years ago

That's fair, I can remove those. it was complaining during the grunt clean task about not having permissions. Will push that change up.

therebelrobot commented 8 years ago

There you go @ybentz. Let me know if you need anything else for this.

grodeska commented 8 years ago

Thanks, @therealrobot!

On Wed, Feb 24, 2016 at 5:39 PM, Trent Oswald notifications@github.com wrote:

There you go @ybentz https://github.com/ybentz. Let me know if you need anything else for this.

— Reply to this email directly or view it on GitHub https://github.com/civicmakers/client/pull/191#issuecomment-188552740.

Lawrence Grodeska Founder & CEO CivicMakers http://civicmakers.com 415-819-8495