civicmapper / culvert-toolkit

GIS tools designed to support analysis of culvert performance within their watershed
https://civicmapper.github.io/culvert-toolkit/
Apache License 2.0
0 stars 0 forks source link

flag duplicate survey situations in the NAACC Data Snapping Tool output table #20

Closed gassc closed 1 year ago

gassc commented 1 year ago

Add a flag indicating if the feature has been resnapped or is relying on its original location. This can be a boolean field.

Background:

Crossings are surveyed more than one time, and it is possible for more than one survey record to come through in NAACC (sometimes one is better than the other, or its a mixed bag, but that's another issue). When these are snapped to a single point on a hydro line using the available tooling, only the location and one of the IDs of the original records is preserved.

So, during the re-snapping process, any original records that don't have a snapped geometry record need to be handled in some way. Currently the code falls back to the feature's original location. However, it would be useful to be able to have a way to find these as a final QAQC step before running the peak-flow/capacity tools.

Having a queryable field will simplify this process. We could also, through ArcPy Toolbox, apply a symbology to the result when auto-added to the map.

gassc commented 1 year ago

Addressed with 5fe566313c99360b487fc6b108996adbc7c8bdf1. The NAACC Snapping tool now adds a "moved" boolean field indicating if the snapping tool moved the feature or not, based on whether or not there was a corresponding feature in the "adjusted geometry" input layer.