For the tool that supports the creation of a curve number, have a way to handle null values in soils hydro classes and landcover classes. It's most likely we'll encounter soil layers without hydrologic classifications. Possible solutions:
determine and build in the logic for an appropriate fallback
expose a user-provided parameter in the toolbox for providing a fallback
ensure that the lookup table itself can be used to handle nulls, e.g., with a blank soil hydro value in the lookup row, the tool will fall back to the provided curve number for the landcover class when the soil is null:
land cover class
soil hydro
curve number
2
45
This could also work to handle conditions where landcover is null but soil is known, or both are null.
That last approach is probably the easiest to implement. The change would happen around this line:
For the tool that supports the creation of a curve number, have a way to handle null values in soils hydro classes and landcover classes. It's most likely we'll encounter soil layers without hydrologic classifications. Possible solutions:
This could also work to handle conditions where landcover is null but soil is known, or both are null.
That last approach is probably the easiest to implement. The change would happen around this line:
https://github.com/civicmapper/peak-flow-calculator/blob/ba57c73e7005a6e086fa17ade25f1511a710d0f0/core/logic/gp.py#L215
Using the ArcPy Spatial Analyst / map algebra toolbox, an
IsNullfunction following or proceeding that line could do the work.Also: create docs around the Curve Number raster creation process, describing how that lookup table is made and adapted for other landcover datasets.