civicmapper / peak-flow-calculator

Calculate peak flow at a point on a DEM using the TR55 methodology and NOAA climate data
MIT License
7 stars 2 forks source link

Curve Number raster assumed to be in meters #8

Open gassc opened 5 years ago

gassc commented 5 years ago

As I've noted the code here: https://github.com/civicmapper/peak-flow-calculator/blob/33addbd4699def0040633238f92b4af337c7ec92/core/logic/calc.py#L84 ...the equation for storage assumes the average curve number was calculated from a raster that had a CRS with meters for units.

It'd be nice to de-hardcode this and use Pint to handle unit conversion for inputs/outputs, as done in a few other places.