search

civicrm / civicrm-setup

MIT License
7 stars 5 forks source link

Simplify SQL and translation pipeline #1

Open totten opened 6 years ago

totten commented 6 years ago

The current version of civicrm-setup still relies on the same SQL files as the old installer -- which means:

To simplify the workflow:

Eventually, this should allow us to remove regen.sh and remove the various civicrm_data.xx_XX.mysql files.

dsnopek commented 6 years ago

I like the sound of this:

(without needing setup.sh / regen.sh / GenCode)

Does this mean that civicrm-setup could be used to power the Drupal 8 installer, allowing us to remove the lines from the process that copy the SQL files?

Ie., this line: https://gist.github.com/dsnopek/56311dbea347874e75180883efabb620#file-installing-civicrm-on-drupal-8-via-composer-sh-L54

That would be amazing!

totten commented 6 years ago

Does this mean that civicrm-setup could be used to power the Drupal 8 installer, allowing us to remove the lines from the process that copy the SQL files?

@dsnopek - Spot-on for both counts:

  1. The civicrm-setup API should be available now for use in the Civi-D8 integration. (Specifically, anything based on master and the current revision of core's composer.json.)
  2. The SQL files would become unnecessary if we addressed this ticket -- making it easier to install from source.
monishdeb commented 6 years ago

I have submitted a PR https://github.com/civicrm/civicrm-setup/pull/9 in this direction, although my changes aren't complete and marked with WIP. In that PR I have added a new event listener civi.setup.generateSchema to generate SQL and DAO files, likewise in regen.sh The new API would be $setup->generateSchema() that need to be called before $setup->installDatabase()