civicrm / civicrm-setup

MIT License
7 stars 5 forks source link

Apply Locale settings files #8

Closed totten closed 6 years ago

totten commented 6 years ago

Port https://github.com/civicrm/civicrm-core/pull/7322/files to a plugin

totten commented 6 years ago

On second thought, I'm not sure we need to do anything -- 7322 wasn't merged. Instead, it was https://github.com/civicrm/civicrm-core/pull/10518 , which should apply on first page-run... which ought to work the same with either installer.

In 10518, there's only a small bit that affects install/ (e.g. it updates the setting). This should do the same thing:

src/civicrm-setup/plugins/installDatabase/SetLanguage.civi-setup.php:      \Civi::settings()->set('lcMessages', $e->getModel()->lang);

I'm gonna close since this issue was speculative (no actual problem report), and (on the same speculative level) it looks OK. But feel free to reopen/resubmit.

CC @bgm