search

civicrm / civicrm-user-guide

Documentation for CiviCRM users
https://docs.civicrm.org/user/en/latest/
54 stars 146 forks source link

dev/core#1046 - Additional help for status check error messages #414

Closed demeritcowboy closed 4 years ago

demeritcowboy commented 4 years ago

This goes along with https://github.com/civicrm/civicrm-core/pull/15483. That PR introduces some status checks that have "Read More..." links in them to get more information, and this PR provides the more information. Note the other PR links to the headings in this PR.

demeritcowboy commented 4 years ago

I'm going to say yes because the situations where it comes up are (a) the parts of the managed entities code that kicks in when civicase is enabled, and (b) the use of <name> in the case type xml. The status checks only run when you have civicase enabled.

Having said that, I personally believe there is a larger discussion about inherent flaws in the name/label concept. I haven't been able to put it into good words yet, but it doesn't come up if you use ids and direction, which the rest of the non-case civi components do.

demeritcowboy commented 4 years ago

Also I should mention the other PR is still pending merge.

homotechsual commented 4 years ago

I'm going to say yes because the situations where it comes up are (a) the parts of the managed entities code that kicks in when civicase is enabled, and (b) the use of <name> in the case type xml. The status checks only run when you have civicase enabled.

Having said that, I personally believe there is a larger discussion about inherent flaws in the name/label concept. I haven't been able to put it into good words yet, but it doesn't come up if you use ids and direction, which the rest of the non-case civi components do.

Thanks - I'll review more extensively now.

homotechsual commented 4 years ago

@demeritcowboy do you feel this is worth committing before the Core PR is live?

demeritcowboy commented 4 years ago

I suppose other than the mention of the status check and that they won't see any status checks, everything else in here is still true either way. So we could call this the egg and the other one the chicken, and then resolve that age-old question and say it's the egg.

And it would be easy to revert or update if needed.

homotechsual commented 4 years ago

Great - approved and merging - can update as needed.