civicrm / coder

Code sniffer configuration for CiviCRM. (Relaxed variant of Drupal CS)
5 stars 11 forks source link

Prevent misspellings of SEPARATOR #12

Closed demeritcowboy closed 4 years ago

demeritcowboy commented 4 years ago

Inspired by https://github.com/civicrm/civicrm-core/pull/18238 and a history in civi that goes back I think forever of repeatedly misspelling this word.

I had to add the line in ruleset.xml with severity 5 to get it to work. That doesn't seem right but I'm not really familiar with customizing sniffer and the "5" came from running with -vvv where the message wasn't clear but seemed like it was skipping it because it wasn't "5".

demeritcowboy commented 4 years ago

After an initial burst of enthusiasm this now seems too specific, and where do you stop. Either spellcheck against a full dictionary, which has its own problems, or don't.