search

civicrm / coder

Code sniffer configuration for CiviCRM. (Relaxed variant of Drupal CS)
5 stars 11 forks source link

Permit array shapes #16

Closed colemanw closed 3 years ago

colemanw commented 3 years ago

Suppress false-positive errors with the new array shapes syntax:

https://blog.jetbrains.com/phpstorm/2021/07/phpstorm-2021-2-release/#array_shapes_phpdoc_syntax_support

eileenmcnaughton commented 3 years ago

@colemanw seems OK - I just wonder if we are on a really old version of coder ?

colemanw commented 3 years ago

Yea probably really old.

eileenmcnaughton commented 3 years ago

@colemanw doesn't look like I have merge rights here anyway

colemanw commented 3 years ago

I've merged it, but not sure how this gets deployed.

eileenmcnaughton commented 3 years ago

@seamuslee001 likely knows

colemanw commented 3 years ago

@seamuslee001 this still doesn't seem to be getting picked up by jenkins; i just had a PR fail checkstyle due to this.

seamuslee001 commented 3 years ago

@colemanw what was needed is this https://github.com/civicrm/civicrm-buildkit/commit/bfbeba04674a76b3f916d59b4eff8f2c2126e655 and then we have to execute a script on each of the test boxes that updates the buildkit code base for each set of test profiles on the box

colemanw commented 3 years ago

Thanks @seamuslee001