civicrm / coder

Code sniffer configuration for CiviCRM. (Relaxed variant of Drupal CS)
5 stars 11 forks source link

Allow variadic parameters - port of Drupal Coder #2878783 #9

Closed seamuslee001 closed 4 years ago

seamuslee001 commented 4 years ago

…adic functions

I tested this by applying the patch locally Checking out @colemanw 's PR https://github.com/civicrm/civicrm-core/pull/16372 and then running civilint on the the file Civi/Api4/Action/Setting/Get.php which is something that Jenkins had kicked up a fuss about https://test.civicrm.org/job/CiviCRM-Core-PR/31673/checkstyleResult/new/ and the result was

seamus@civicrmdevelopment:~/buildkit/build/47-test/sites/all/modules/civicrm$ git checkout api4Magic
Branch 'api4Magic' set up to track remote branch 'api4Magic' from 'coleman'.
Switched to a new branch 'api4Magic'
seamus@civicrmdevelopment:~/buildkit/build/47-test/sites/all/modules/civicrm$ civilint Civi/Api4/Action/Setting/Get.php
===========================[ Identify Files ]===========================
PHP Files:
 * Civi/Api4/Action/Setting/Get.php
===============================[ php -l ]===============================
===============================[ phpcs  ]===============================

ping @totten

seamuslee001 commented 4 years ago

Drupal coder issue https://www.drupal.org/project/coder/issues/2878783

totten commented 4 years ago

Good idea.

I tried out Coleman's PR locally and confirmed: