Closed seamuslee001 closed 4 years ago
…adic functions
I tested this by applying the patch locally Checking out @colemanw 's PR https://github.com/civicrm/civicrm-core/pull/16372 and then running civilint on the the file Civi/Api4/Action/Setting/Get.php which is something that Jenkins had kicked up a fuss about https://test.civicrm.org/job/CiviCRM-Core-PR/31673/checkstyleResult/new/ and the result was
Civi/Api4/Action/Setting/Get.php
seamus@civicrmdevelopment:~/buildkit/build/47-test/sites/all/modules/civicrm$ git checkout api4Magic Branch 'api4Magic' set up to track remote branch 'api4Magic' from 'coleman'. Switched to a new branch 'api4Magic' seamus@civicrmdevelopment:~/buildkit/build/47-test/sites/all/modules/civicrm$ civilint Civi/Api4/Action/Setting/Get.php ===========================[ Identify Files ]=========================== PHP Files: * Civi/Api4/Action/Setting/Get.php ===============================[ php -l ]=============================== ===============================[ phpcs ]===============================
ping @totten
Drupal coder issue https://www.drupal.org/project/coder/issues/2878783
Good idea.
I tried out Coleman's PR locally and confirmed:
…adic functions
I tested this by applying the patch locally Checking out @colemanw 's PR https://github.com/civicrm/civicrm-core/pull/16372 and then running civilint on the the file
Civi/Api4/Action/Setting/Get.php
which is something that Jenkins had kicked up a fuss about https://test.civicrm.org/job/CiviCRM-Core-PR/31673/checkstyleResult/new/ and the result wasping @totten