search

civicrm / org.civicrm.civicase

CiviCase Extension
Other
9 stars 35 forks source link

ts() > E::ts() #134

Closed UshaMakoa closed 4 years ago

UshaMakoa commented 4 years ago

This doesn't solve the problem that several .html pages (for example Dashboard) with ts() inside doesn't translate (and we don't even see the strings in Transifex).

colemanw commented 4 years ago

Thanks for the PR @UshaMakoa. I don't see use statements at the tops of these files, which would mean E would be undefined causing a crash.

UshaMakoa commented 4 years ago

I made the correction, can you check please? Have you any answer regarding the dashboard.html and the strings that aren't translated?

colemanw commented 4 years ago

Ok this looks good now.

colemanw commented 4 years ago

I don't see any apparent reason why the html files would fail to be translated. ts() appears to be working in the templates.

demeritcowboy commented 4 years ago

In chat in the translation channel our current theory is that it's not so much ts isn't working as that this extension isn't in-app, and so by policy its strings don't appear in transifex. (Unconfirmed.)