search

civicrm / org.civicrm.civicase

CiviCase Extension
Other
9 stars 35 forks source link

CRM-21406 - Add export cases action #87

Closed colemanw closed 6 years ago

colemanw commented 6 years ago

This depends on https://github.com/civicrm/civicrm-core/pull/11254

@guanhuan @mukeshcompucorp there is a css bug in ShorDitch which is causing this to not display properly. The circled text is missing, (I manipulated css in my console to show it). The offending line is

.crm-container.ui-dialog .ui-dialog-content h3 {
  display: none;
}

I consider that to be a very bad css rule. I would advise whoever wrote it to go back to the drawing board and find a different solution to whatever problem they were trying to solve.

exportcases

jamienovick commented 6 years ago

@guanhuan @mukeshcompucorp I'd like to know who is creating lines of CSS display:none in Shoreditch. Not really acceptable?!

And who reviewed the PR and approved it?

colemanw commented 6 years ago

display:none is fine to use if it's done in a targeted way. My problem with this rule is it's lack of specificity. It hides all h3 elements in every dialog without regard to context or content.

mukeshcompucorp commented 6 years ago

@jamienovick , I found out this one, it's from https://github.com/civicrm/org.civicrm.shoreditch/commit/9375492bd3dbcc4d911ce3d1e5357c4373e79980 This seems a blind move but, as it was an year old css we did not had backstopjs and I think no body noticed such thing. only thing in mind would be some code is moved to other file.

But, again I agree this one is bad code and should be handled. Purpose of this code should be to hide only title (h3) from popup which are under public vacancy list /civicrm/vacancy/publiclisting?reset=1

PS: scss/civicrm/vacancies/_vacancies.scss should be part of CiviHR so, as per current status that file does not exist in shoreditch

I'm adding this in my note and will tackle it while working on CiviHR tickets as it's barely 2-4 minute of work.