Closed deb1990 closed 4 years ago
Just noting I tried this & it fixed the issue I see on 5.31 at
http://dmaster.local/civicrm/admin/uf/group/update?action=update&id=1&context=group
vs
@eileenmcnaughton Thanks for checking. PR should be ready within the next week.
@deb1990 also, why did the package-lock.json file change?
I never knew how this works, but now I have a answer https://stackoverflow.com/a/50868741.
The package-lock.json is supposed
to be updated every time you run npm install
. Otherwise we need to run npm ci
to download exact versions. So in development its fine to use npm install
and in production npm ci
should be used.
@deb1990 can you please use nvm use
and then npm install
? the package-lock.json
is not supposed to change when installing local packages. The only reason for changing is when installing using a different Node version than the one enforced by NVM/NPM.
5.31 drops tomorrow so you probably want to merge this & tag a 5.31 compatible release
@eileenmcnaughton Thanks for the reminder. It will be merged today.
@eileenmcnaughton This is the release to support CiviCRM 5.31 buttons. https://github.com/civicrm/org.civicrm.shoreditch/releases/tag/1.0.0-beta.4
yay
Overview
Recently in the Civicrm Core(https://github.com/civicrm/civicrm-core/pull/18410), all the
input
type button markups has been changed tobutton
elements. This caused a lot of styles to break when using Shoreditch theme. So this PR fixes those UI related style issues.Before (Only showing some examples)
After (Only showing some examples)
Technical Details
Changed css selector from
input
tobutton
inMade adjustments to the following files to support new markup
// no extra css required for .crm-i, as items inside buttons are auto aligned scss/civicrm/administer/display/_display.scss
// styles for .crm-i removed, as items inside buttons are auto aligned, and crm-i-button does not exist anymore scss/civicrm/search/pages/_advanced-search.scss