Closed deb1990 closed 4 years ago
@deb1990 : Could we please mention in the technical details why we need to add js/jquery-ui-popup.js
? Do you think we should add details how are we doing this Also assigning the height of the ui-dialog-content dynamically
?
Few other things.
Overview
jQuery UI modals do not take the full height of the screen, when making it fullscreen. But now we want the popups to take full height also. So this PR implements that.
Before
After
Technical Details
Added a
js/jquery-ui-popup.js
file, whichfullscreen
class when expand button is pressed.ui-dialog-content
dynamically.// this is the height we are setting var contentHeight = windowHeight - (titleBarHeight + menuHeight + buttonContainerHeight);
scss/jquery/overrides/_ui-dialog.scss
, added styles specific tofullscreen
class, to apply full height.Comment
Backstop JS tests were not run, because currently we dont have any scenarios written for expanding modals.