Closed deb1990 closed 3 years ago
The Cancel Button border was wrong when inside Bootstrap. This PR fixes it.
The button color was applied in https://github.com/civicrm/org.civicrm.shoreditch/commit/e948807afe6732c947a6a1b7456ecd59c09bad52#diff-d70c310903cd4caf4066146aa6a16294bb25f009a7f6a7f7b85d63c494525f3dR12. But there is no explanation of why this color was applied and $gray-dark is the correct color.
$gray-dark
We never saw this before, because before CiviCRM 5.35 changes, there was an extra input element for buttons, and that input element had the correct colors.
Backstop Report: https://github.com/compucorp/backstopjs-config/actions/runs/675356335
Overview
The Cancel Button border was wrong when inside Bootstrap. This PR fixes it.
Before
After
Technical details
The button color was applied in https://github.com/civicrm/org.civicrm.shoreditch/commit/e948807afe6732c947a6a1b7456ecd59c09bad52#diff-d70c310903cd4caf4066146aa6a16294bb25f009a7f6a7f7b85d63c494525f3dR12. But there is no explanation of why this color was applied and
$gray-darkis the correct color.We never saw this before, because before CiviCRM 5.35 changes, there was an extra input element for buttons, and that input element had the correct colors.
Backstop Report: https://github.com/compucorp/backstopjs-config/actions/runs/675356335