search

civicrm / org.civicrm.shoreditch

Other
45 stars 59 forks source link

reply-to drop down does not fully appear #531

Open jmcclelland opened 3 years ago

jmcclelland commented 3 years ago

When you have the "Enable Custom Reply-To" configured (via CiviMail -> Mailer Settings), the drop down box disappears:

reply-to

The code and css is identical to the code/css for the From address except the From address has a default value that populates it. The default value holds the height, but without a default reply-to, it gets collapsed.

I managed a work around with this CSS code. Bootstrap sets the height to auto. Not sure if it's the right approach or not:

 #bootstrap-theme .select2-container .select2-choice { 
    height: 26px;
  }
mlutfy commented 3 years ago

@jmcclelland Thanks for the fix. I added this to our fork, if it helps: https://github.com/coopsymbiotic/shoreditch/commit/5f2ca3f86478a9f30aa54d5c17868aeb5f10b133 - I only see that bug on the Mosaico forms.

jmcclelland commented 3 years ago

@mlutfy - oh, nice, It looks like you have some nice additions to your fork (but also at least one non-generic patch). I wonder if we could get any of your other fixes here?

mlutfy commented 3 years ago

@jmcclelland We try to report upstream when it makes sense. Ex: #526, #456. Others are hacks/tweaks for Drupal8/WordPress support, or questions of personal taste, such as increasing the contrast (avoid grey text on grey background).

MarcMichalsky commented 1 year ago

Are there any plans to merge commit 5f2ca3f? It's annoying and it won't be fixed on the Mosaico side either.