search

civicrm / org.civicrm.shoreditch

Other
45 stars 59 forks source link

CATL-2243: Fix quick search result dropdown #544

Closed olayiwola-compucorp closed 2 years ago

olayiwola-compucorp commented 2 years ago

Overview

This PR fixes the issue with missing spacing in the quick search result dropdown, this issue is caused by a change in the dropdown item CSS class in the recent CiviCRM version.

The CSS class used to be ui-menu-item-wrapper but now ui-menu-item-uiMenuItemWrapper, added support for the two classes to ensure backward compatibility.

Before

On an older version of CiviCRM, 5.35.2

Screenshot 2022-07-22 at 08 08 40

On a newer version of CiviCRM, 5.39.1

Screenshot 2022-07-22 at 08 07 46

After

On a newer version of CiviCRM, 5.39.1

Screenshot 2022-07-22 at 09 21 55

Backstop JS Report

Backstop JS report here

olayiwola-compucorp commented 2 years ago

Yes @erawat, I mentioned in the PR description that the previously supported version would not be affected.

added support for the two classes to ensure backward compatibility.