Closed olayiwola-compucorp closed 1 year ago
This PR aligns the button with their help icon on the contacts group page.
Behaviour in the latest CiviCRM (tested with 5.51.3) with Shoreditch, the help icons are away from the buttons.
The default behaviour in CiviCRM without Shoreditch.
Behaviour in the latest CiviCRM (tested with 5.51.3) with Shoreditch.
In this https://github.com/civicrm/civicrm-core/commit/044fc18f4a8afdcfd2ef1a552d05be09a6f3b1b6 included in CiviCRM 5.42.0, buttons in the contacts group page were added to a single div group and a CSS rule to float the icon was added, this is causing an issue in Shoreditch theme forcing the helo icons to float away from their respective buttons.
We simply set the float to none, for the help icons to be rightly placed beside their respective buttons.
https://github.com/compucorp/backstopjs-config/actions/runs/3574589840
Overview
This PR aligns the button with their help icon on the contacts group page.
Before
Behaviour in the latest CiviCRM (tested with 5.51.3) with Shoreditch, the help icons are away from the buttons.
After
The default behaviour in CiviCRM without Shoreditch.
Behaviour in the latest CiviCRM (tested with 5.51.3) with Shoreditch.
Technical Details
In this https://github.com/civicrm/civicrm-core/commit/044fc18f4a8afdcfd2ef1a552d05be09a6f3b1b6 included in CiviCRM 5.42.0, buttons in the contacts group page were added to a single div group and a CSS rule to float the icon was added, this is causing an issue in Shoreditch theme forcing the helo icons to float away from their respective buttons.
We simply set the float to none, for the help icons to be rightly placed beside their respective buttons.
Backstop JS Report
https://github.com/compucorp/backstopjs-config/actions/runs/3574589840