civicrm / org.civicrm.shoreditch

Other
45 stars 59 forks source link

Front end url's treat differently for shoreditch #563

Closed yashodha closed 12 months ago

yashodha commented 1 year ago

We have different result on these 2 urls'

https://www.example.org/civicrm/event/info%3Fid%3D443%26reset%3D1 shoreditch is loaded

https://www.example.org/civicrm/event/info?id=443&reset=1 shoreditch is not loaded, looks different

yashodha commented 1 year ago

@olayiwola-compucorp have you encountered the same?

yashodha commented 1 year ago

@olayiwola-compucorp you could check here : https://dmaster.demo.civicrm.org/civicrm/event/info?reset=1&id=3

https://dmaster.demo.civicrm.org/civicrm/event/info%3Fid%3D3%26reset%3D1

olayiwola-compucorp commented 1 year ago

@yashodha, The URLs are the same, save that one is encoded, I haven't encountered it myself.

Do you think this is an issue?

yashodha commented 12 months ago

@olayiwola-compucorp the issue is in the core, where get method in CRM/Core/Menu.php doesn't recognise _ispublic for the url https://dmaster.demo.civicrm.org/civicrm/event/info%3Fid%3D3%26reset%3D1 but does so for https://dmaster.demo.civicrm.org/civicrm/event/info?reset=1&id=3