search

civicrm / org.civicrm.volunteer

CiviVolunteer extension.
40 stars 64 forks source link

Fix notice against 5.24.0 due to core function signature change #532

Closed eileenmcnaughton closed 4 years ago

eileenmcnaughton commented 4 years ago

The signature for copyValues in 5.24.0 no longer has serialize as a second param. This removes & increments the version so only sites on 5.24.0+ should get the change (This is the strategy I use in all my extensions - ie specifying which civi version each release is tested on.)

eileenmcnaughton commented 4 years ago
Screen Shot 2020-02-24 at 11 15 34 AM
ginkgomzd commented 4 years ago

Thanks @eileenmcnaughton , I'm taking a look at refactoring this because it looks like the only reason this override was created was to default one field.

I have more free time now, so I will see if I can finally get that release out. I recall that I found a bug in the rc. I will try to take the shortest path to a release.

eileenmcnaughton commented 4 years ago

@ginkgomzd would be great to see that release out

JoeMurray commented 4 years ago

+:+1: about getting a release out. There seem to have been a few rc branches created but no release in a long time.

ginkgomzd commented 4 years ago

superseded by #536

particulary: https://github.com/civicrm/org.civicrm.volunteer/pull/536/commits/b1ab67269fb992ce96a4758b29ab86131abd53d8