search

civicrm / org.civicrm.volunteer

CiviVolunteer extension.
40 stars 64 forks source link

Incompatible with 5.60+ ? #594

Closed jofranz closed 1 month ago

jofranz commented 1 year ago

These methods got removed from core:

org.civicrm.volunteer/CRM/Volunteer/BAO/Project.php:          $roles[$role_id] = CRM_Core_OptionGroup::getLabel(
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerNeedTest.php:      "visibility_id" => CRM_Core_OptionGroup::getValue('visibility', 'public', 'name'),
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectContactTest.php:      'relationship_type_id' => CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_owner', 'name'),
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectContactTest.php:    $relTypeId = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_owner', 'name');
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectContactTest.php:    $relTypeLabel = CRM_Core_OptionGroup::getLabel(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, $relTypeId);
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectTest.php:    $bao->relationship_type_id = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_owner', 'name');
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectTest.php:    $bao->relationship_type_id = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_manager', 'name');
org.civicrm.volunteer/tests/phpunit/CRM/Volunteer/BAO/AssignmentTest.php:      'relationship_type_id' => CRM_Core_OptionGroup::getValue('volunteer_project_relationship', 'volunteer_beneficiary', 'name'),
org.civicrm.volunteer/tests/phpunit/CRM/Volunteer/BAO/ProjectTest.php:    $relType = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP,
MegaphoneJon commented 1 year ago

https://github.com/civicrm/org.civicrm.volunteer/pull/589 fixes the getValue() references, which gets it working for my client, though they're admittedly a light user.

mlutfy commented 1 month ago

Since the PR 589 was merged, I will take the liberty of closing this issue.