added address lookup retry for DC API endpoint

civictechdc / ancfinder

A website about DC's Advisory Neighborhood Commission system.

http://ancfinder.org/

Creative Commons Zero v1.0 Universal

43 stars 36 forks source link

added address lookup retry for DC API endpoint #129

Closed witte-de-with closed 9 years ago

stvnrlly commented 9 years ago

Nice. This'll have the same error message as now if it doesn't work the second time?

witte-de-with commented 9 years ago

I think the exception now will be slightly different, since before we had that assert in there, while now we are using (at Josh's helpful suggestion) the raise_for_status() method to do the same thing. We can adjust the exception text as necessary though.

witte-de-with commented 9 years ago

Just checking on this one -- any changes you want me to make to the exception handling?

stvnrlly commented 9 years ago

For whatever reason, we didn't look at this tonight. As far as I can tell, it looks fine, but I'm not sure how to test it. @JoshData: any ideas?

stvnrlly commented 9 years ago

Thanks, @JKesMc9tqIQe9M!