Fix /dist route (issue-228)

NoahCarnahan commented 7 years ago

Description

Adds a route for /dist, which is just a redirect to /.

Motivation and Context

When the site is deployed to github pages, the home page redirects to https://codefordc.org/dc-campaign-finance-watch/dist/, which just shows the top bar navigation with a blank page.

The bigger issue here might actually be with how github pages is being used for this project. I haven't hosted a site with it before, but perhaps on the gh-pages branch the contents of /dist/ should just be in the root of the project? This PR will hopefully be at least an acceptable short term solution.

How Has This Been Tested?

Tested in local dev environment.

Screenshots (highly recommended):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] I've talked through the changes with a team lead
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Questions:

I'm not super familiar with the build/deployment process for react/webpack projects. Should this PR have also updated /dist/? Is $ yarn dist all that's needed to do that? Also, should I create a follow up PR into the gh-pages branch to make this change live, or is there an automated process for that?

romoy commented 7 years ago

@NoahCarnahan your changes are live, thank you for the fix! I'm digging the avatar.

NoahCarnahan commented 7 years ago

Thanks for the clear contributing guidelines. It made it easy to pick up!

civictechdc / dc-campaign-finance-watch