civictechdc / rfj_expungement

Tool for pro bono attorneys helping the Rising for Justice’s Expungement Clinic
MIT License
9 stars 23 forks source link

Frontend polish issues/nits #72

Open cmazzullo opened 4 years ago

cmazzullo commented 4 years ago
xee5ch commented 4 years ago

I was going through issues, @cmazzullo, since I am at Day of Service (I just noticed you were here too) and I was curious how many of these are still relevant. Shall we catch up and figure out how many are remaining?

froi commented 4 years ago

Thank you for making this list @cmazzullo and for following up on this @xee5ch

I took a look at these, here are the results:

The "To Top" button doesn't do anything

This is still the case.

The "Save to PDF" button doesn't work

This feature has not been implemented. See #22

The "Pre-rendered page" button (the little lightning bolt) is baffling - should this be here? I might just be missing something

This icon/button is only present when running the app in developer mode ( npm run dev ). It is added there by Next.js.

Date Inputs should describe the format they expect in the help text

The date components to tell you the format once you write a number. There is an issue though. When loading the site the DOB date field loads with an error. This breaks the functionality of the component and it does not shoe the intended format.

When you use the date picker to the right of the field and the error is cleared the component starts to work as expected.

I think this should be filed as a bug.

"Evaluator Name" is skipped over when tabbing through the form (accessibility issue)

This was apparently fixed.

"Persist Case Data" is unclear in function - could use some help text

Agreed. Any suggestions?

Sometimes default text in Client DOB box isn't deleted after manually selecting a date (flaky)

It's not the default text but the input label. The expected behavior is that the label will slide about the input field and stay above it one a value is entered or picked.

This should be filed as a bug.

"Case terminated on" box always has Today as the default date

I'm unsure about this one. We will need to talk to to our project partner.

Big "Case Info" title at the top of the page seems superfluous

Agreed but should be taken up to the general team.