search

civictechindex / CTI-website-frontend

Join a worldwide movement to catalog 
every open source 
civic tech project.
https://civictechindex.org
MIT License
30 stars 30 forks source link

Orgs page state 1042 #1136

Closed bruceplai closed 2 years ago

bruceplai commented 2 years ago

Closes #1042 

* Update organizations.spec tests

* Clean up routes in App.js

* Add query params to navigation.js

* Update header and footer link lists to handle query params

* Update Organizations page to handle contrib and status params

* Update Organizations page to handle various nav scenarios
bruceplai commented 2 years ago

Great suggestion. I'll clean up the header spec

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit e51b425b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.7% (-0.2% change).

View more on Code Climate.

maxskewes commented 2 years ago

All the functionality is there as far as I can tell, and the code looks really good. However there is too much going on that I don't fully understand to feel comfortable approving the PR myself. If someone with a better comprehension wants to take a look, I'm sure they would provide more apt and informed feedback.

bruceplai commented 2 years ago

All the functionality is there as far as I can tell, and the code looks really good. However there is too much going on that I don't fully understand to feel comfortable approving the PR myself. If someone with a better comprehension wants to take a look, I'm sure they would provide more apt and informed feedback.

Thanks for the feedback! Any review from @mealthebear @bhaggya @nrrao would be much appreciated