civictheme / uikit

UI atomic component-based library with Storybook integration
https://uikit.civictheme.io/
GNU General Public License v2.0
6 stars 5 forks source link

[#389] Removed aria-label from button with 'is_new_window'. #390

Closed alan-cole closed 1 month ago

alan-cole commented 1 month ago

https://github.com/civictheme/uikit/issues/389

Checklist before requesting a review

Changed

  1. The aria-label in this case would override whatever text was present within the button, meaning buttons lose context if used with a screen reader.

Screenshots

Screenshot 2024-09-25 at 2 31 19 pm

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 13.87%. Comparing base (343d1ff) to head (15b2d31). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #390 +/- ## ======================================= Coverage 13.87% 13.87% ======================================= Files 27 27 Lines 1290 1290 Branches 307 307 ======================================= Hits 179 179 Misses 894 894 Partials 217 217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

🚀 Deployed on https://66f39424ac1c22a7f3222715--civictheme-uikit.netlify.app