Link underline thickness is currently incorrect at 2px instead of 1px - Githubissues

civictheme / uikit

UI atomic component-based library with Storybook integration

https://uikit.civictheme.io/

GNU General Public License v2.0

5 stars 5 forks source link

Link underline thickness is currently incorrect at 2px instead of 1px #394

Open richardgaunt opened 1 week ago

richardgaunt commented 1 week ago

Summary

Figma content link is 1px thickness on the underline https://www.figma.com/design/i5NTcjBsg2zVjAxUvOl5oU/CivicTheme%3A-Design-System-v1.8.0?node-id=3596-136186&t=ZllSnfZFPvnJcZvG-4

But currently its 2px in the UI Kit.

PR fixing the issue has been provided https://github.com/civictheme/uikit/pull/393

Steps to reproduce

Compare Figma: https://www.figma.com/design/i5NTcjBsg2zVjAxUvOl5oU/CivicTheme%3A-Design-System-v1.8.0?node-id=3596-136186&t=ZllSnfZFPvnJcZvG-4

Storybook: https://uikit.civictheme.io/?path=/story/atoms-content-link--content-link&knob-Is%20external_General=true&knob-Link%20hidden%20text_General=Link%20hidden%20text&knob-Text_General=Link%20text&knob-Theme_General=light&knob-Title_General=Link%20title&knob-URL_General=http://example.com/roytp

Observed outcome

The observed underline thickness is 2px instead of 1px

Expected outcome

The observed underline thickness is 1px

sonamchaturvedi28 commented 6 days ago

Test Env: DEV Test Status: PASS Test Result:

Content link is 1px thickness on the underline.