civictheme / uikit

UI atomic component-based library with Storybook integration
https://uikit.civictheme.io/
GNU General Public License v2.0
6 stars 5 forks source link

[#341] Added disable and single icon flags to text-icon. #403

Closed alan-cole closed 1 month ago

alan-cole commented 1 month ago

Checklist before requesting a review

Changed

  1. Added icon_group_disabled and icon_single_only flags to text-icon. This will allow for grouping to be disabled, and for external links to display in-place of icons.
  2. Applied the use of the new settings to cards that were using non-standard styling of links with icons. They include: navigation-card, next-step, publication-card and subject-card.

Screenshots

Screenshot 2024-10-04 at 4 27 14 pm Screenshot 2024-10-04 at 4 26 59 pm Screenshot 2024-10-04 at 4 26 49 pm Screenshot 2024-10-04 at 4 26 41 pm Screenshot 2024-10-04 at 4 26 26 pm

github-actions[bot] commented 1 month ago

🚀 Deployed on https://66ff921890696cb91ba3697f--civictheme-uikit.netlify.app

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 13.87%. Comparing base (7315692) to head (3cd915e). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #403 +/- ## ======================================= Coverage 13.87% 13.87% ======================================= Files 27 27 Lines 1290 1290 Branches 307 307 ======================================= Hits 179 179 Misses 894 894 Partials 217 217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richardgaunt commented 1 month ago

Fixes #341