Updated button mixins to live in base for improved re-usability.

alan-cole commented 1 month ago

Checklist before requesting a review

[ ] I have formatted the subject to include the issue number as [#123] Verb in past tense with a period at the end.
[x] I have provided information in the Changed section about WHY something was done if this was a bespoke implementation.
[x] I have performed a self-review of my code.
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have run new and existing relevant tests locally with my changes, and they have passed.
[ ] I have provided screenshots, where applicable.

Changed

Button mixins are used on button and chip components, so rather than place them within the button component, they should be moved into base.
Aside from code structure improvements; this also fixes a compile issue when using a custom sass compilation toolkit.

Screenshots

github-actions[bot] commented 1 month ago

🚀 Deployed on https://671a3759e64640db04fad253--civictheme-uikit.netlify.app

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 13.87%. Comparing base (23efae5) to head (49dbb75). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #408 +/- ## ======================================= Coverage 13.87% 13.87% ======================================= Files 27 27 Lines 1290 1290 Branches 307 307 ======================================= Hits 179 179 Misses 894 894 Partials 217 217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

civictheme / uikit